dash: Consider additions for separator visibility

The children variable holds the icons that were originally in
the dash. For the separator visibility, we should consider the
icons that are in the dash after the update, so we must consider
additions as well as removals.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1659>

diff --git a/js/ui/dash.js b/js/ui/dash.js
index 16893f9765d2dff8dbfc04b6f02083f41864326b..6b4c114e7966b3752b33c8448d2830aa8aa72f9b 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -745,7 +745,7 @@ var Dash = GObject.registerClass({
 
         // Update separator
         const nFavorites = Object.keys(favorites).length;
-        const nIcons = children.length - removedActors.length;
+        const nIcons = children.length + addedItems.length - removedActors.length;
         if (nFavorites > 0 && nFavorites < nIcons) {
             if (!this._separator) {
                 this._separator = new St.Widget({